Allow custom bucket boundaries per Histogram#300
Merged
ryanfkeepers merged 21 commits intoalcionai:mainfrom Apr 29, 2026
Merged
Allow custom bucket boundaries per Histogram#300ryanfkeepers merged 21 commits intoalcionai:mainfrom
ryanfkeepers merged 21 commits intoalcionai:mainfrom
Conversation
ryanfkeepers
requested changes
Apr 24, 2026
Contributor
ryanfkeepers
left a comment
ryanfkeepers
left a comment
There was a problem hiding this comment.
Please see comments. In particular:
- unit test fixups.
- automatic usage of the default boundaries.
- removal of the histogramConfig struct.
Co-authored-by: Keepers <ryan.keepers@veeam.com>
Co-authored-by: Keepers <ryan.keepers@veeam.com>
Co-authored-by: Keepers <ryan.keepers@veeam.com>
Co-authored-by: Keepers <ryan.keepers@veeam.com>
Co-authored-by: Keepers <ryan.keepers@veeam.com>
Co-authored-by: Keepers <ryan.keepers@veeam.com>
ryanfkeepers
approved these changes
Apr 28, 2026
Contributor
ryanfkeepers
left a comment
ryanfkeepers
left a comment
There was a problem hiding this comment.
A couple remaining tiny nits. Thanks for all the effort!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OTel Go SDK uses explicit bucket boundaries that top out at 10,000. Any observation above that lands in the
+Infoverflow bucket, and since Kibana'spercentile()uses linear interpolation within buckets it silently maxes out at 10,000. Customizing the bucket boundaries is needed to measure latencies above 10,000The OTel mechanism is explicit bucket boundaries via
metric.WithExplicitBucketBoundariesat instrument creation time — per-instrument, not a global MeterProvider view.Changes:
ExponentialBoundaries(min, max, count)— logarithmically-spaced buckets mirroring Prometheus'sExponentialBucketsRangeDefaultLatencyBoundariesMs— 20 buckets from 1–60,000WithBoundaries(...) HistogramOptiononHistogram[N]andRegisterHistogramRecordbucket placement via aManualReader-backed OTel context